-
Notifications
You must be signed in to change notification settings - Fork 385
Refactor builddrivers.py for safety and error handling #1552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
54J4N
commented
Jan 8, 2026
- Replace all os.system() calls with safe alternatives to prevent command injection
- Fix bare except: clause that could catch KeyboardInterrupt and SystemExit
- Add path sanitization to prevent shell injection attacks
- Fix PHP version validation with proper regex instead of flawed string comparison
- Replace hardcoded backslashes with os.sep for cross-platform compatibility
- Add proper error handling for os.chdir() operations
- Fix variable reference bugs (self.repo vs repo, self.branch vs branch)
- Prevent infinite loops in get_local_source() with proper empty path validation
- Add comprehensive source folder validation before copying
- Improve error messages and log file display on build failure
- Fix interactive mode input validation and retry logic
- Replace all os.system() calls with safe alternatives to prevent command injection - Fix bare except: clause that could catch KeyboardInterrupt and SystemExit - Add path sanitization to prevent shell injection attacks - Fix PHP version validation with proper regex instead of flawed string comparison - Replace hardcoded backslashes with os.sep for cross-platform compatibility - Add proper error handling for os.chdir() operations - Fix variable reference bugs (self.repo vs repo, self.branch vs branch) - Prevent infinite loops in get_local_source() with proper empty path validation - Add comprehensive source folder validation before copying - Improve error messages and log file display on build failure - Fix interactive mode input validation and retry logic
|
@54J4N please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|