Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make all moduleResolution values available #4545

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Commits on Jun 2, 2024

  1. fix: make all moduleResolution values available

    adds additional members to the `ModuleResolutionKind` enum to make all
    possible `moduleResolution` values available.
    
    the values are based on the enum in `typescriptServices.js`, namely:
    ```javascript
          ModuleResolutionKind = /* @__PURE__ */ ((ModuleResolutionKind3) => {
            ModuleResolutionKind3[ModuleResolutionKind3["Classic"] = 1] = "Classic";
            ModuleResolutionKind3[ModuleResolutionKind3["NodeJs"] = 2] = "NodeJs";
            ModuleResolutionKind3[ModuleResolutionKind3["Node10"] = 2] = "Node10";
            ModuleResolutionKind3[ModuleResolutionKind3["Node16"] = 3] = "Node16";
            ModuleResolutionKind3[ModuleResolutionKind3["NodeNext"] = 99] = "NodeNext";
            ModuleResolutionKind3[ModuleResolutionKind3["Bundler"] = 100] = "Bundler";
            return ModuleResolutionKind3;
    ```
    
    from a developer experience perspective I would actually prefer if the
    enum was replaced with the string values that you would use in
    `tsconfig.json` as I'd find this more intuitive, but this would be a
    larger breaking change.
    mnahkies committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    5e6bc12 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2024

  1. Configuration menu
    Copy the full SHA
    5a3dca3 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. Configuration menu
    Copy the full SHA
    f7512b8 View commit details
    Browse the repository at this point in the history