-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: fix and migrate smoke tests to Playwright #1961
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mxschmitt
commented
May 10, 2020
•
edited
Loading
edited
- Migrated and fixed the smoke tests over to Playwright and execute them on webkit/firefox/chromium as discussed with @rebornix
- Adjusted the GitHub Actions, so they run also on a Pull Requests
Thanks for the good work! |
sthagen
added a commit
to sthagen/microsoft-monaco-editor
that referenced
this pull request
May 31, 2020
feat: fix and migrate smoke tests to Playwright (microsoft#1961)
joeveiga
pushed a commit
to swimlane/monaco-editor
that referenced
this pull request
Apr 28, 2021
* Added section in Monarch docs for Inspect Tokens development helper * Updated h2 id * Add link to diff.html * Fix issue where test page does not run in IE * Prepare for 0.20.0 * 0.20.0 * Fixes microsoft#1826 (downgrade typedoc) * Update CHANGELOG.md * Clarify IE11 support * Clarify IE11 state * Remove usage of X-UA-Compatible * Monarch documentation changes * Add test page for running the editor-esm-bundle output * update deps * update deps * Load the editor after `<body>` is defined * feat: fix and migrate smoke tests to Playwright (microsoft#1961) * feat: migrate e2e tests to Playwright * fix: OS dependency * fix: race condition * fix: increased launch timeout * ci: fixed smoke tests by increasing timeout * update deps * more dependencies updates * update deps * Adding terraform / hcl samples * Semantic tokens provider example * Adopt latest `monaco-json` * update deps * adopt latest monaco plugins * Remove ES6 syntax from example * Update example: allow peek definition * Adds support for both quotes in the TS side * Use a regex for injecting `vs/editor/editor.api` as a dependency * fix: A 'declare' modifier cannot be used in an already ambient context * update to latest `monaco-typescript` * Add test case for 2040 * Correct url of Microsoft logo * update to newer node version * Add test page for 2096 * Minor edits * Avoid using internals * Update CONTRIBUTING.md * Prepare for 0.21.0 * update codicons path * update to latest deps * 0.21.0 * Add missing samples * Update CHANGELOG.md * Avoid scrollbars in the runner iframe * Fixes microsoft#2153: Add a dispose() method to the code lens provider * update screenshot * Prepare for `0.21.1` * Fix version number * 0.21.1 * Link to example of editor integrated with `vscode-textmate` and `vscode-oniguruma` * Fixes microsoft#2155: Adopt latest typedoc themes * Fix comment in sample * Prepare for 0.21.2 * 0.21.2 * Missing breaking change I'm not sure what release starting 0.21.0 caused it, not other methods being static now beyond parse() and file() in monaco.uri. Regards and keep doing this amazing project awesomER! * Bump highlight.js from 10.2.0 to 10.4.1 Bumps [highlight.js](https://github.com/highlightjs/highlight.js) from 10.2.0 to 10.4.1. - [Release notes](https://github.com/highlightjs/highlight.js/releases) - [Changelog](https://github.com/highlightjs/highlight.js/blob/master/CHANGES.md) - [Commits](highlightjs/highlight.js@10.2.0...10.4.1) Signed-off-by: dependabot[bot] <support@github.com> * Fixed indentation in C# sample * Bump ini from 1.3.5 to 1.3.7 Bumps [ini](https://github.com/isaacs/ini) from 1.3.5 to 1.3.7. - [Release notes](https://github.com/isaacs/ini/releases) - [Commits](npm/ini@v1.3.5...v1.3.7) Signed-off-by: dependabot[bot] <support@github.com> * Fix documentation (microsoft#2212) * update webpack related deps * Remove unknown CLI flag * Add node module caching * Remove deprecated webpack 5 option * Remove step which moved to the vscode CI * Remove CI workflow since vscode runs it now (e.g. https://github.com/microsoft/vscode/runs/1619014477?check_suite_focus=true) * Add back typescript * Add repro for microsoft#2264 * update monaco-editor-core * update changelog * 0.21.3 * Update dependencies * prepare 0.22.0 * 0.22.0 * update to latest `monaco-editor-core` * Prepare for `0.22.1` * 0.22.1 * Prepare for `0.22.2` * 0.22.2 * Prepare for `0.22.3` * 0.22.3 * Adopt latest typedoc * Rename folder to typedoc * Move typedoc related files together * Prepare for 0.23.0 * 0.23.0 * Add Thank you notes * Improve website script * Add SECURITY.md * Document EOL for Classic Edge Co-authored-by: Josh Goldberg <josh@codecademy.com> Co-authored-by: Alexandru Dima <alexdima@microsoft.com> Co-authored-by: nrayburn <nrayburn@cybermemphis.com> Co-authored-by: Max Schmitt <max@schmitt.mx> Co-authored-by: Hugo Fonseca <1098293+fonsecas72@users.noreply.github.com> Co-authored-by: KapitanOczywisty <44417092+KapitanOczywisty@users.noreply.github.com> Co-authored-by: Orta <git@orta.io> Co-authored-by: ZHAO Jinxiang <xiaoxiangmoe@gmail.com> Co-authored-by: Tuan Le Minh <minhtuanchannhan@gmail.com> Co-authored-by: Gittenburg <gittenburg@fsinf.at> Co-authored-by: David Gonzalez <luminaxster@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Petr Onderka <gsvick@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.