-
Notifications
You must be signed in to change notification settings - Fork 55
[moc] Implement Graceful Shutdown Option for VM Stop Operation #404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[moc] Implement Graceful Shutdown Option for VM Stop Operation #404
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix up the description to include screenshots from manual testing performed since this precedes automated testing.
Please fix up the title of the PR to match the changes
| repeated VirtualMachine VirtualMachines = 1; | ||
| VirtualMachineOperation OBSOLETE_OperationType = 2 [deprecated=true]; | ||
| ProviderAccessOperation OperationType = 3; | ||
| bool SkipShutdown = 4; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks stale, remove.
rpc/common/moc_common_common.proto
Outdated
| VirtualMachine_Pause = 608; | ||
| VirtualMachine_Save = 609; | ||
| VirtualMachine_Remove_Iso_Disk = 610; | ||
| VirtualMachine_Poweroff = 611; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
VirtualMachine_StopGraceful?
| message VirtualMachineOperationRequest { | ||
| repeated VirtualMachine VirtualMachines = 1; | ||
| VirtualMachineOperation OperationType = 2; | ||
| bool SkipShutdown = 3; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is leftover and needs to be cleaned up.
|
@arg5739 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
Problem Statement
When users select "Stop" for a virtual machine (VM) through the portal or CLI, the system currently performs an immediate "Turn Off" operation rather than executing a graceful shutdown. This behavior does not align with user expectations and has become a significant pain point, as customers anticipate a proper shutdown sequence when choosing to stop their VM.

Related PRs
[MOC] #404
[WSSD-SDK] https://github.com/microsoft/wssd-sdk-for-go/pull/342
[MOC-SDK] microsoft/moc-sdk-for-go#359
[MOCCLI] https://github.com/microsoft/moccli/pull/352
[CloudAgent] In progress
[NodeAgent] In progress
WorkItem
https://msazure.visualstudio.com/One/_workitems/edit/30775126
Summary of changes
These PRs accomplish the following:
The parameter to request non-graceful VM shutdown. True value indicates non-graceful shutdown whereas false indicates otherwise. Default value for this flag is false if not specified
Testing
In progress