Improve text scale support on TextBox and NavigationView buttons #9644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
the
needs-triage
|
@microsoft-github-policy-service agree |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some TexBlocks with glyphs don't properly ignore the system text accessibility setting and, for the NavigationView search button, can scale beyond the control limits. The design guidance.
Description
Disable
IsTextScaleFactorEnabledon theNavigationViewPaneSearchButtonStyle, ported back from WinUI 3.microsoft-ui-xaml/controls/dev/NavigationView/NavigationView_themeresources.xaml
Line 343 in 2a60e27
Disable
IsTextScaleFactorEnabledon the RevealButtonstyle for the PasswordBox control.Disable
IsTextScaleFactorEnabledon the DeleteButtonStyle for the TextBox/NumberBox/PasswordBox/AutoSuggestBox controlsMotivation and Context
Provide better accessibility text size support.
How Has This Been Tested?
Created a test app WinUI 2 with and without the changes.
Screenshots (if appropriate):