Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only add VCLibs for supported architectures #579 #580

Merged
merged 2 commits into from
Apr 18, 2019
Merged

Only add VCLibs for supported architectures #579 #580

merged 2 commits into from
Apr 18, 2019

Conversation

dotMorten
Copy link
Contributor

Fixes #579

@dotMorten dotMorten requested a review from a team as a code owner April 18, 2019 18:19
@jevansaks
Copy link
Member

Thanks! Queuing a CI build so we can get a full package for testing: https://dev.azure.com/ms/microsoft-ui-xaml/_build/results?buildId=11240 .

@jevansaks @dotMorten
Update build/NuSpecs/MUXControls-Nuget-FrameworkPackage.props
a254c92 
Co-Authored-By: dotMorten <1378165+dotMorten@users.noreply.github.com>
@jevansaks
Copy link
Member

Re-queued the full build on latest update: https://dev.azure.com/ms/microsoft-ui-xaml/_build/results?buildId=11249

@jevansaks jevansaks self-assigned this Apr 18, 2019
@jevansaks
Copy link
Member

I confirmed this fixes the error in an AnyCPU project but UWP app projects still work. Thanks @dotMorten for the fix!

@jevansaks jevansaks merged commit b21f748 into microsoft:master Apr 18, 2019
jevansaks pushed a commit that referenced this pull request Apr 18, 2019
@dotMorten @jevansaks
Only add VCLibs for supported architectures #579 (#580)
8610a01 
* Only add VCLibs for supported architectures #579

* Update build/NuSpecs/MUXControls-Nuget-FrameworkPackage.props

Co-Authored-By: dotMorten <1378165+dotMorten@users.noreply.github.com>
@jevansaks jevansaks added the release note PR that we want to call out in the next release summary label Apr 19, 2019
@msft-github-bot
Copy link
Collaborator

🎉Microsoft.UI.Xaml v2.1.190405004.1 has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot msft-github-bot mentioned this pull request Apr 19, 2019
Closed
@msft-github-bot
Copy link
Collaborator

🎉Microsoft.UI.Xaml v2.1.190405004.1 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jevansaks jevansaks jevansaks approved these changes

Assignees

@jevansaks jevansaks

Labels
release note PR that we want to call out in the next release summary
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

There shouldn't be an build error for libraries targeting AnyCPU or below the version version.
3 participants
@dotMorten @jevansaks @msft-github-bot