Add check to only open flyout if a menubaritem has items #2889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msft-github-bot
added
the
needs-triage
ranjeshj
reviewed
Jul 13, 2020
| <MenuFlyoutItem Text="Font..."/> | ||
| </muxc:MenuBarItem> | ||
|
|
||
| <muxc:MenuBarItem Title="No children"/> |
There was a problem hiding this comment.
Thanks @chingucoding. Could we add a test ? I think you can click and look at all the open popups to validate.
There was a problem hiding this comment.
Added new interaction test now.
Felix-Dev
reviewed
Jul 13, 2020
| [TestMethod] | ||
| public void EmptyMenuBarItemNoPopupTest() | ||
| { | ||
| if (PlatformConfiguration.IsDevice(DeviceType.Phone)) |
There was a problem hiding this comment.
Do we still need that? I don't think we are doing any tests on Windows Mobile devices any longer.
There was a problem hiding this comment.
I thought the same. I think we should look at all test holistically at some point and remove obsolete checks.
There was a problem hiding this comment.
This does look like dead code. @kmahone to verify this codepath is not hit in any of the configurations we run tests in.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
StephenLPeters
removed
the
needs-triage
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a check to only open a menubaritems flyout if it has items.
Motivation and Context
Closes #2740
How Has This Been Tested?
Tested manually:
Screenshots (if appropriate):