Fix for Issue:2066 - around-the-end segments were played incorrectly #2069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ectly. The bug was introduced by an earlier change that got the direction wrong in a call to ::nextafterf which meant that we jumped backwards in time instead of continuing forwards. I've added a test for around-the-end segments, and did a big cleanup of our tests because I was struggling to understand them.
msft-github-bot
added
the
needs-triage
ranjeshj
added
area-AnimatedVisualPlayer
team-Controls
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for Issue:2066 - around-the-end segments were played incorrectly
Description
The bug was introduced by an earlier change that got the direction wrong in a call to ::nextafterf which meant that we jumped backwards in time instead of continuing forwards.
I've added a test for around-the-end segments, and did a big cleanup of our tests because I was struggling to understand them.
Motivation and Context
"Fixes #2066"
How Has This Been Tested?
I ran the automated tests. And fixed up the automated tests to make them more reliable after having issues with them.