Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix new project script and update feature area props file. #1843

Merged
merged 4 commits into from
Jan 15, 2020
Merged

fix new project script and update feature area props file. #1843

merged 4 commits into from
Jan 15, 2020

Conversation

ranjeshj
Copy link
Contributor

@ranjeshj ranjeshj commented Jan 14, 2020 •
edited
Loading

Fix for (1) and (3) of #1836

This fixes the feature are flags and updates the script to provide the correct values.

@ranjeshj ranjeshj requested review from jesbis and teaP January 14, 2020 19:18
@msft-github-bot msft-github-bot added the needs-triage Issue needs to be triaged by the area owners label Jan 14, 2020
jesbis
jesbis reviewed Jan 14, 2020
View reviewed changes
FeatureAreas.props Outdated Show resolved Hide resolved
jesbis
jesbis reviewed Jan 14, 2020
View reviewed changes
FeatureAreas.props Outdated Show resolved Hide resolved
StephenLPeters
StephenLPeters approved these changes Jan 14, 2020
View reviewed changes
Copy link
Contributor

@StephenLPeters StephenLPeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ranjeshj ranjeshj merged commit 6b4f0a8 into master Jan 15, 2020
@ranjeshj ranjeshj deleted the user/ranjeshj/fixscript branch January 15, 2020 00:28
@ranjeshj ranjeshj removed the needs-triage Issue needs to be triaged by the area owners label Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jesbis jesbis jesbis left review comments

@StephenLPeters StephenLPeters StephenLPeters approved these changes

@teaP teaP Awaiting requested review from teaP

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ranjeshj @StephenLPeters @jesbis @msft-github-bot