Some ThemeResource fixes #1638
Merged
Some ThemeResource fixes #1638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Found some issues while testing on RS2 for another bug.
FlyoutPresenter: Transient background doesn't work properly on RS2 which makes flyout background transparent. Adding conditional xaml to fallback to previous non-transient colors on older os versions.
ContentDialog: There are quirks in code that makes it only show theme transitions in higher os versions. LayoutRoot is always collapsed in RS2 since the transition doesn't play. Also used conditional xaml to fix that.
How Has This Been Tested?
Manually tested on RS2 and RS3.