Skip to content

Conversation

kaiguo
Copy link
Contributor

@kaiguo kaiguo commented Oct 14, 2019

Description

Adding 4px rounded corners for CommandBar overflow menu.

Motivation and Context

Fixes #1431.

How Has This Been Tested?

Added visual tree verification tests for CommandBar overflow menu and CommandBar itself.

Screenshots (if appropriate):

image

@kaiguo kaiguo requested a review from a team as a code owner October 14, 2019 18:46
@mdtauk
Copy link
Contributor

mdtauk commented Oct 14, 2019

@kaiguo In that example image, shouldn't the bottom two corners have a 0 CornerRadius, as it is extending from the bottom bar.

Also does this take into account the full width flyout, when in a narrow window/phone?

Copy link
Member

@kmahone kmahone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@kaiguo
Copy link
Contributor Author

kaiguo commented Oct 14, 2019

@kaiguo Kai Guo FTE In that example image, shouldn't the bottom two corners have a 0 CornerRadius, as it is extending from the bottom bar.

Also does this take into account the full width flyout, when in a narrow window/phone?

I think @chigy reviewed with design team and we decided to make it 4px for all corners, #1431 (comment).

And I believe it applies to full width flyouts too.

@kaiguo kaiguo added auto merge This PR will be merged once all checks pass and removed auto merge This PR will be merged once all checks pass labels Oct 14, 2019
@chigy
Copy link
Member

chigy commented Oct 14, 2019

@kaiguo Kai Guo FTE In that example image, shouldn't the bottom two corners have a 0 CornerRadius, as it is extending from the bottom bar.
Also does this take into account the full width flyout, when in a narrow window/phone?

I think @chigy reviewed with design team and we decided to make it 4px for all corners, #1431 (comment).

And I believe it applies to full width flyouts too.

That is correct. The image shared is what we expect the design to be.

@kaiguo kaiguo merged commit 94002c4 into master Oct 14, 2019
@kaiguo kaiguo deleted the user/kaiguo/commandbar-overflow-cornerradius branch October 14, 2019 23:09
@jevansaks jevansaks added the release note PR that we want to call out in the next release summary label Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Styling release note PR that we want to call out in the next release summary
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CommandBar's flyout portion needs also to be rounded
5 participants