Fix ContentDialog CornerRadius #1405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llongley
approved these changes
Oct 3, 2019
jevansaks
added
needs-cherrypicktorelease
|
Now that there's visual verification, can you add some visual verification coverage to verify that the corners of things are rounded correctly? |
Yeah there's already a test covering it and I just updated the master file ed42d60. |
jevansaks
removed
the
needs-cherrypicktorelease
This was referenced Dec 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The ContentDialog project was not properly referenced by mux dll so the CornerRadius style changes didn't take effect. Fixed project referencing issue also updated default button styles.
Motivation and Context
Fixes #1345
How Has This Been Tested?
Verified both manually and in visual tree test.
Screenshot after fix: