Skip to content

Fix TreeViewItem CheckBox aligment #1320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 12, 2019
Merged

Fix TreeViewItem CheckBox aligment #1320

merged 1 commit into from
Sep 12, 2019

Conversation

kaiguo
Copy link
Contributor

@kaiguo kaiguo commented Sep 11, 2019 •
edited
Loading

Fixes #1294

TreeViewItem CheckBox was not vertically centered when item height or font size changes. Changed VerticalAlignment from Stretch to Center.

Annotation 2019-09-11 165243 Annotation 2019-09-11 165046

@kaiguo kaiguo requested a review from a team as a code owner September 11, 2019 23:54
@jevansaks jevansaks added the needs-cherrypicktorelease PR tagged for cherry-pick to the current release branch (but not yet picked) label Sep 12, 2019
@kaiguo kaiguo merged commit e2b045e into master Sep 12, 2019
@kaiguo kaiguo deleted the user/kaiguo/fix-treeview-checkbox-alignment branch September 12, 2019 18:26
jevansaks pushed a commit that referenced this pull request Sep 12, 2019
@kaiguo @jevansaks
Fix CheckBox aligment (#1320)
7094bc6
@jevansaks jevansaks added release note PR that we want to call out in the next release summary and removed needs-cherrypicktorelease PR tagged for cherry-pick to the current release branch (but not yet picked) labels Sep 12, 2019
@msft-github-bot
Copy link
Collaborator

🎉Microsoft.UI.Xaml v2.2.190917002 has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot msft-github-bot mentioned this pull request Sep 19, 2019
Closed
@msft-github-bot
Copy link
Collaborator

🎉Microsoft.UI.Xaml v2.3.191007001-prerelease has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@jevansaks jevansaks jevansaks approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
area-TreeView release note PR that we want to call out in the next release summary
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CheckBox not aligned correctly in TreeView
3 participants
@kaiguo @msft-github-bot @jevansaks