Add visual tree verification baseline #1130
Conversation
kaiguo
force-pushed
the
user/kaiguo/visual-tree-test
branch
2 times, most recently
from
65a2d25 to
c0684f2
Compare
|
What criteria was used to determine which controls would get masters? |
We brought in a lot of templates from OS repo for rounded corner and shadow changes, but the code and tests of those controls are still in OS, that means we have 0 test coverage for them in MUX. So I'm targeting those controls first. I've also randomly added some other controls with complicated visuals or might be impacted by rounded corners. But I think ideally we should have master file for every control in our repo @jevansaks ? |
kaiguo
force-pushed
the
user/kaiguo/visual-tree-test
branch
from
71da6c1 to
de96da1
Compare
kaiguo
force-pushed
the
user/kaiguo/visual-tree-test
branch
from
7a34931 to
0a3ed15
Compare
|
This is ready to be re-reviewed now. Latest changes in the PR description @jevansaks @kmahone. |
| @@ -0,0 +1,149 @@ | |||
| [Windows.UI.Xaml.Controls.Grid] | |||
| Padding=0,0,0,0 | |||
There was a problem hiding this comment.
Is there a script to copy the masters out of the pipeline? Or what is the procedure?
There was a problem hiding this comment.
Current procedure is you'd have to open that HelixTestFailureDumps.html file and click on the links to download. I guess I'll write another script to download and replace the old masters to make it easier/faster.
There was a problem hiding this comment.
Added a script in tools folder : )
| @@ -142,10 +142,23 @@ private static void WalkThroughTree(DependencyObject node, Visitor visitor) | |||
| public class DefaultFilter : IFilter | |||
| { | |||
There was a problem hiding this comment.
Will we be able to use this helper in the release tests too? I think that would help unlock a class of testing there too.
There was a problem hiding this comment.
This is in TestAppUtils so we should be able to use it in the C# version NuGet test.
Is this script working? If I go to the build: and look at the html file, it is empty. Refers to: build/Helix/CreateHelixTestFailureDumps.ps1:2 in 0584c50. [](commit_id = 0584c50, deletion_comment = False) |
If it's a successful run then there won't be anything. This one had some actual failures, https://dev.azure.com/ms/microsoft-ui-xaml/_build/results?buildId=37518. We probably shouldn't create the html file at all if the run is successful, I'll update. |
kaiguo
force-pushed
the
user/kaiguo/visual-tree-test
branch
from
d1e7c06 to
c226e7b
Compare
Added tests to verify controls' visual trees and captured current content as the baseline.
Failed visual tree test will generate a new master file and it'll be included in HelixTestFailureDumps.html (use to be crashdumps.html) in the artifacts drop folder. HelixTestFailureDumps.html now contains screenshots, crash dumps, and new visual tree master files when they are available (screenshot below).