Update build scripts to use common metadata file #534

hallipr · 2025-09-23T00:24:13Z

What does this PR do?

Updates all build, test, package and release scripts to use a common build_info.json file
- This file coordinates version numbers, package properties and platform details for all build artifacts
- all other build and pack scripts should use build_info rather than pulling properties from project files
Removes the static build matrix
- build_info.json also includes dynamically generated build and tests matrices
- rather than special casing steps in yaml, we should update the build matrix in the script and use simple boolean variables to conditionally run pipeline steps
Updates the pack scripts to be server-generic. All ids and server specific settings that go into a package should be pulled from build_info.json, which is built using properties from the servers' project files

Sample build_info.json

GitHub issue number?

closes #53

Pre-merge Checklist

eng/pipelines/templates/jobs/build.yml

eng/pipelines/build-matrix.json

eng/scripts/Build-Code.ps1

Copilot

Pull Request Overview

This PR centralizes build configuration by introducing a build_info.json file that coordinates version numbers, package properties, and platform details across all build artifacts. The changes replace static build matrices with dynamically generated ones and update pack scripts to be server-generic.

Updates all build, test, package and release scripts to use a common build_info.json file
Removes static build matrices in favor of dynamically generated ones from the build info
Converts pack scripts to be server-generic by pulling configuration from build_info.json

Reviewed Changes

Copilot reviewed 33 out of 36 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
servers//src/.csproj	Reorganized packaging properties into consistent sections (npm, docker, dnx/nuget, vsix)
eng/scripts/New-BuildInfo.ps1	New script that generates the centralized build_info.json configuration file
eng/scripts/Build-Code.ps1	Updated to use build_info.json instead of individual project properties
eng/scripts/Pack-*.ps1	Refactored packaging scripts to read from build_info.json for server-agnostic configuration
eng/pipelines/	Updated pipeline templates to use dynamic matrices from build_info.json
eng/scripts/helpers/PathHelpers.ps1	New helper for repository path utilities

servers/Template.Mcp.Server/src/Template.Mcp.Server.csproj

servers/Azure.Mcp.Server/src/Azure.Mcp.Server.csproj

eng/scripts/New-BuildInfo.ps1

eng/scripts/Pack-Nuget.ps1

eng/scripts/Build-Code.ps1

eng/pipelines/templates/jobs/build.yml

hallipr · 2025-10-06T23:28:29Z

Also we should support pipeline tagging in the same way we do for unified pull request builds in the language repos, so that users can filter by server name in the tags dropdown for the pipeline.

I'll add a followup PR

weshaggard · 2025-10-13T22:55:54Z

eng/pipelines/templates/jobs/docker/release-docker.yml

+
+        $version = $serverInfo.version
+        Write-Host "Setting variable DockerImageVersion to $version"
+        Write-Host "##vso[task.setvariable variable=DockerImageVersion;isOutput=true]$version"


nit: Do these need to be output variables now?

weshaggard · 2025-10-13T22:59:29Z

eng/scripts/Pack-Npm.ps1

 $platformSourcePath = "$RepoRoot/eng/npm/platform"

+# When running locally, ignore missing artifacts instead of failing
+$ignoreMissingArtifacts = $env:TF_BUILD -ne 'true'


nit: I think we have shared function for this in common.

weshaggard · 2025-10-14T00:01:50Z

eng/pipelines/templates/jobs/initialize.yml

+  - task: Powershell@2
+    displayName: "Create build info file"
+    name: CreateBuildInfo
+    condition: and(succeeded(), ne(variables['NoPackagesChanged'],'true'))


Do we not need an empty build_info if NoPackagesChanged is set?

weshaggard · 2025-10-14T00:05:23Z

eng/pipelines/templates/jobs/sign-and-pack.yml

+      ServerName: ${{ parameters.ServerName }}
+    MatrixConfigs:
+      - Name: build_matrix
+        Path: eng/pipelines/build-matrix.json


This matrix no longer exists. You will need to try to share the matrix of the build.

weshaggard · 2025-10-14T00:12:24Z

eng/scripts/Build-Code.ps1

-            Write-Host "Building version $version, $os-$arch in $outputDir" -ForegroundColor Green
+    foreach ($os in $OperatingSystem) {
+        foreach ($arch in $Architecture) {
+            $platform = $server.platforms


You might need to check that $platform is not empty or contains more than one entry.

weshaggard · 2025-10-14T00:14:06Z

eng/scripts/Build-Code.ps1

+    if ($CleanBuild) {
+        # Clean up any previous build artifacts.
+        Write-Host "Removing existing bin and obj folders"
+        Remove-Item * -Recurse -Include 'obj', 'bin' -Force -ProgressAction SilentlyContinue


Why clean this way? I would call "dotnet clean" or "dotnet rebuild"

weshaggard · 2025-10-14T00:14:59Z

eng/scripts/Build-Docker.ps1

+                "."
+            )
+
+            Invoke-LoggedCommand "docker build $($dockerArgs -join ' ')"


We should handle the error code on these calls.

github-project-automation bot added this to Azure MCP Server Sep 23, 2025

github-project-automation bot moved this to Untriaged in Azure MCP Server Sep 23, 2025

joshfree moved this from Untriaged to In Progress in Azure MCP Server Sep 23, 2025

hallipr force-pushed the users/pahallis/metadata-json branch 17 times, most recently from 11811f5 to 43e55ed Compare September 30, 2025 18:40

hallipr linked an issue Sep 30, 2025 that may be closed by this pull request

Build artifacts should have package-generic metadata #53

Open

hallipr force-pushed the users/pahallis/metadata-json branch 5 times, most recently from 107bb97 to 0e55b21 Compare September 30, 2025 21:24

weshaggard reviewed Sep 30, 2025

View reviewed changes

eng/pipelines/templates/jobs/build.yml Show resolved Hide resolved

weshaggard reviewed Sep 30, 2025

View reviewed changes

eng/pipelines/build-matrix.json Outdated Show resolved Hide resolved

hallipr force-pushed the users/pahallis/metadata-json branch from 0e55b21 to 38feff4 Compare September 30, 2025 21:52

weshaggard reviewed Sep 30, 2025

View reviewed changes

eng/scripts/Build-Code.ps1 Outdated Show resolved Hide resolved

hallipr requested a review from a team as a code owner October 6, 2025 17:54

hallipr requested review from KarishmaGhiya, alzimmermsft, Copilot, jongio, joshfree, msalaman, tmeschter and wbreza October 6, 2025 17:54

Copilot AI reviewed Oct 6, 2025

View reviewed changes

hallipr requested review from benbp, chidozieononiwu and scbedd October 6, 2025 23:36

hallipr force-pushed the users/pahallis/metadata-json branch 2 times, most recently from af781a5 to d186241 Compare October 7, 2025 19:21

joshfree assigned hallipr Oct 12, 2025

joshfree added the Central-EngSys label Oct 12, 2025

joshfree added this to the 2025-10 milestone Oct 12, 2025

Update build scripts to use common metadata file

89e3351

hallipr force-pushed the users/pahallis/metadata-json branch from 3af3798 to 89e3351 Compare October 13, 2025 16:53

hallipr requested review from conniey and g2vinay October 13, 2025 16:55

weshaggard reviewed Oct 13, 2025

View reviewed changes

weshaggard reviewed Oct 14, 2025

View reviewed changes

Update build scripts to use common metadata file #534

Are you sure you want to change the base?

Update build scripts to use common metadata file #534

Uh oh!

Conversation

hallipr commented Sep 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

GitHub issue number?

Pre-merge Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hallipr commented Oct 6, 2025

Uh oh!

weshaggard Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

weshaggard Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

weshaggard Oct 14, 2025

Choose a reason for hiding this comment

Uh oh!

weshaggard Oct 14, 2025

Choose a reason for hiding this comment

Uh oh!

weshaggard Oct 14, 2025

Choose a reason for hiding this comment

Uh oh!

weshaggard Oct 14, 2025

Choose a reason for hiding this comment

Uh oh!

weshaggard Oct 14, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

hallipr commented Sep 23, 2025 •

edited

Loading