Add `azmcp sql db export` command and unit tests #526

achyuth-ms · 2025-09-20T00:02:18Z

What does this PR do?

Add azmcp sql db export command and unit tests

[Any additional context, screenshots, or information that helps reviewers]

GitHub issue number?

[Link to the GitHub issue this PR addresses]

Pre-merge Checklist

achyuth-ms · 2025-09-25T23:33:35Z

/azp run mcp - pullrequest - live

azure-pipelines · 2025-09-25T23:33:41Z

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

Copilot

Pull Request Overview

This PR adds a new SQL database export command to allow exporting Azure SQL databases to BACPAC files in Azure Storage. This functionality enables users to create logical backups of their database schema and data for archiving or migration purposes.

Implements a complete export command with validation, service integration, and comprehensive test coverage
Adds necessary models, options, and service methods to support the export functionality
Updates documentation and configuration to register the new command

Reviewed Changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
`DatabaseExportCommandTests.cs`	Comprehensive unit tests for the new export command covering success, error, and validation scenarios
`SqlSetup.cs`	Registers the new DatabaseExportCommand in dependency injection and command registration
`SqlService.cs`	Implements ExportDatabaseAsync method with Azure Resource Manager integration
`ISqlService.cs`	Adds interface definition for the export database operation
`SqlOptionDefinitions.cs`	Defines command line options for storage URI, keys, admin credentials, and auth type
`DatabaseExportOptions.cs`	Options class for binding export-specific parameters
`SqlDatabaseExportResult.cs`	Result model containing export operation details
`SqlJsonContext.cs`	Adds JSON serialization support for the new export result types
`DatabaseExportCommand.cs`	Main command implementation with validation, execution logic, and error handling
`README.md`	Updates documentation with export command example
`CHANGELOG.md`	Documents the new export functionality
`e2eTestPrompts.md`	Adds test prompts for the export command
`azmcp-commands.md`	Documents the export command syntax and parameters

tools/Azure.Mcp.Tools.Sql/src/Services/SqlService.cs

Copilot · 2025-09-25T23:34:53Z

...ure.Mcp.Tools.Sql/tests/Azure.Mcp.Tools.Sql.UnitTests/Database/DatabaseExportCommandTests.cs

+        // Debug: Add detailed error info
+        if (response.Status != HttpStatusCode.OK)
+        {
+            throw new Exception($"Expected OK but got {response.Status}. Message: {response.Message}");
+        }
+        Assert.Equal(HttpStatusCode.OK, response.Status);


Debug/temporary code should be removed from production tests. This debugging logic with the throw statement appears to be temporary code that should be cleaned up.

Suggested change

// Debug: Add detailed error info

if (response.Status != HttpStatusCode.OK)

{

throw new Exception($"Expected OK but got {response.Status}. Message: {response.Message}");

}

Assert.Equal(HttpStatusCode.OK, response.Status);

Assert.Equal(HttpStatusCode.OK, response.Status); // Optionally, add a message: Assert.Equal(HttpStatusCode.OK, response.Status, $"Message: {response.Message}");

tools/Azure.Mcp.Tools.Sql/src/Commands/Database/DatabaseExportCommand.cs

ericshape · 2025-09-26T21:34:38Z

about the failed pipelines, you could run "dotnet format" in your local's mcp repo and then commit the format updates (i.e. white space)

jongio · 2025-09-30T01:09:42Z

servers/Azure.Mcp.Server/README.md

 All Azure MCP tools in a single server. The Azure MCP Server implements the [MCP specification](https://modelcontextprotocol.io) to create a seamless connection between AI agents and Azure services. Azure MCP Server can be used alone or with the [GitHub Copilot for Azure extension](https://marketplace.visualstudio.com/items?itemName=ms-azuretools.vscode-azure-github-copilot) in VS Code.  This project is in Public Preview and implementation may significantly change prior to our General Availability.

-[![Install Azure MCP in VS Code](https://img.shields.io/badge/VS_Code-Install_Azure_MCP_Server-0098FF?style=flat-square&logo=visualstudiocode&logoColor=white)](https://vscode.dev/redirect?url=vscode:extension/ms-azuretools.vscode-azure-mcp-server) [![Install Azure MCP in VS Code Insiders](https://img.shields.io/badge/VS_Code_Insiders-Install_Azure_MCP_Server-24bfa5?style=flat-square&logo=visualstudiocode&logoColor=white)](https://vscode.dev/redirect?url=vscode-insiders:extension/ms-azuretools.vscode-azure-mcp-server) [![Install Azure MCP in Visual Studio](https://img.shields.io/badge/Visual_Studio-Install_Azure_MCP_Server-C16FDE?style=flat-square&logo=visualstudio&logoColor=white)](https://marketplace.visualstudio.com/items?itemName=github-copilot-azure.GitHubCopilotForAzure2022)  [![Install Azure MCP Server](https://img.shields.io/badge/IntelliJ%20IDEA-Install%20Azure%20MCP%20Server-1495b1?style=flat-square&logo=intellijidea&logoColor=white)](https://plugins.jetbrains.com/plugin/8053)
+[![Install Azure MCP in VS Code](https://img.shields.io/badge/VS_Code-Install_Azure_MCP_Server-0098FF?style=flat-square&logo=visualstudiocode&logoColor=white)](https://vscode.dev/redirect?url=vscode:extension/ms-azuretools.vscode-azure-mcp-server) [![Install Azure MCP in VS Code Insiders](https://img.shields.io/badge/VS_Code_Insiders-Install_Azure_MCP_Server-24bfa5?style=flat-square&logo=visualstudiocode&logoColor=white)](https://vscode.dev/redirect?url=vscode-insiders:extension/ms-azuretools.vscode-azure-mcp-server) [![Install Azure MCP in Visual Studio](https://img.shields.io/badge/Visual_Studio-Install_Azure_MCP_Server-C16FDE?style=flat-square&logo=visualstudio&logoColor=white)](https://marketplace.visualstudio.com/items?itemName=github-copilot-azure.GitHubCopilotForAzure2022)


are you removing jetbrains

do you need to rebase?

jongio · 2025-09-30T01:10:57Z

tools/Azure.Mcp.Tools.Sql/src/Commands/Database/DatabaseExportCommand.cs

+        options.StorageKeyType = parseResult.GetValueOrDefault(SqlOptionDefinitions.StorageKeyTypeOption);
+        options.AdminUser = parseResult.GetValueOrDefault(SqlOptionDefinitions.AdminUserOption);
+        options.AdminPassword = parseResult.GetValueOrDefault(SqlOptionDefinitions.AdminPasswordOption);
+        options.AuthType = parseResult.GetValueOrDefault(SqlOptionDefinitions.AuthTypeOption);


@xiangyan99 pls review

jongio · 2025-09-30T01:11:20Z

tools/Azure.Mcp.Tools.Sql/src/Commands/Database/DatabaseExportCommand.cs

+        var options = BindOptions(parseResult);
+
+        // Additional validation for export-specific parameters
+        if (string.IsNullOrEmpty(options.StorageUri))


Add to Validators @alzimmermsft

jongio · 2025-09-30T01:12:09Z

tools/Azure.Mcp.Tools.Sql/src/Models/SqlDatabaseExportResult.cs

+    [property: JsonPropertyName("operationId")] string? OperationId,
+    [property: JsonPropertyName("requestId")] string? RequestId,
+    [property: JsonPropertyName("status")] string? Status,
+    [property: JsonPropertyName("queuedTime")] DateTimeOffset? QueuedTime,
+    [property: JsonPropertyName("lastModifiedTime")] DateTimeOffset? LastModifiedTime,
+    [property: JsonPropertyName("serverName")] string? ServerName,
+    [property: JsonPropertyName("databaseName")] string? DatabaseName,
+    [property: JsonPropertyName("storageUri")] string? StorageUri,
+    [property: JsonPropertyName("message")] string? Message


seems like we might not want to duplicate the names, can you use SqlOptionDefinitions.

jongio · 2025-09-30T01:12:44Z

tools/Azure.Mcp.Tools.Sql/src/Services/SqlService.cs

+    {
+        ValidateRequiredParameters(serverName, resourceGroup, subscription, databaseName);
+
+        if (string.IsNullOrEmpty(storageUri))


Why not add to ValidateRequiredParameters

github-project-automation bot added this to Azure MCP Server Sep 20, 2025

github-project-automation bot moved this to Untriaged in Azure MCP Server Sep 20, 2025

joshfree moved this from Untriaged to In Progress in Azure MCP Server Sep 23, 2025

achyuth-ms force-pushed the sql_cli_db_ex-ip branch 2 times, most recently from 9935ac2 to 991b484 Compare September 25, 2025 23:29

achyuth-ms marked this pull request as ready for review September 25, 2025 23:33

achyuth-ms requested review from ericshape and jeremyfrosti as code owners September 25, 2025 23:33

Copilot AI review requested due to automatic review settings September 25, 2025 23:33

achyuth-ms requested review from a team and mitesh-pv as code owners September 25, 2025 23:33

achyuth-ms requested review from alzimmermsft, conniey, fanyang-mono, jongio, joshfree, tmeschter and vukelich September 25, 2025 23:33

Copilot AI reviewed Sep 25, 2025

View reviewed changes

achyuth-ms changed the title ~~add sql db export command~~ Add azmcp sql db export command and unit tests Sep 25, 2025

achyuth-ms changed the title ~~Add azmcp sql db export command and unit tests~~ Add azmcp sql db export command and unit tests Sep 25, 2025

achyuth-ms force-pushed the sql_cli_db_ex-ip branch from b0c9b23 to e1bd045 Compare September 29, 2025 19:09

achyuth-ms added 3 commits September 29, 2025 12:26

changes for sql db export

9061dcb

rebase and error code fix

41ea76c

format fix

e77a6ec

achyuth-ms force-pushed the sql_cli_db_ex-ip branch from e1bd045 to e77a6ec Compare September 29, 2025 19:27

ericshape approved these changes Sep 29, 2025

View reviewed changes

jongio requested changes Sep 30, 2025

View reviewed changes

Add azmcp sql db export command and unit tests #526

Are you sure you want to change the base?

Add azmcp sql db export command and unit tests #526

Uh oh!

Conversation

achyuth-ms commented Sep 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

GitHub issue number?

Pre-merge Checklist

Uh oh!

achyuth-ms commented Sep 25, 2025

Uh oh!

azure-pipelines bot commented Sep 25, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Copilot AI Sep 25, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ericshape commented Sep 26, 2025

Uh oh!

jongio Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

jongio Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

jongio Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

jongio Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

jongio Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

jongio Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Add `azmcp sql db export` command and unit tests #526

Add `azmcp sql db export` command and unit tests #526

achyuth-ms commented Sep 20, 2025 •

edited

Loading