Skip to content

Conversation

@lihuoran
Copy link
Contributor

@lihuoran lihuoran commented May 13, 2022

Description

  • Checkout RL modifications in v0.3.
  • Rewrite SC RL example using RLComponentBundle.

Most changes in this PR is RL related updates that are not related to SC scenario. We could only pay attention to:

  • maro\rl\rl_component\rl_component_bundle.py
  • maro\rl\training\training_manager.py
  • examples\supply_chain\

Linked issue(s)/Pull request(s)

Type of Change

  • Non-breaking bug fix
  • Breaking bug fix
  • New feature
  • Test
  • Doc update
  • Docker update

Related Component

  • Simulation toolkit
  • RL toolkit
  • Distributed toolkit

Has Been Tested

  • OS:
    • Windows
    • Mac OS
    • Linux
  • Python version:
    • 3.6
    • 3.7
  • Key information snapshot(s):

Needs Follow Up Actions

  • New release package
  • New docker image

Checklist

  • Add/update the related comments
  • Add/update the related tests
  • Add/update the related documentations
  • Update the dependent downstream modules usage

lihuoran and others added 5 commits April 24, 2022 10:51
* Refactor rollout logic. Allow multiple sampling in one epoch, so that we can generate more data for training.

AC & PPO for continuous action policy; refine AC & PPO logic.

Cherry pick RL changes from GYM-DDPG

Cherry pick RL changes from GYM-SAC

Minor error in doc string

* Add min_n_sample in template and parser

* Resolve PR comments. Fix a minor issue in SAC.
* CIM passed

* Update workers

* Refine annotations

* VM passed

* Code formatting.

* Minor import loop issue

* Pass batch in PPO again

* Remove Scenario

* Complete docs

* Minor

* Remove segment

* Optimize logic in RLComponentBundle

* Resolve PR comments

* Move 'post methods from RLComponenetBundle to EnvSampler
@lihuoran lihuoran requested a review from Jinyu-W May 13, 2022 05:13
@lihuoran lihuoran force-pushed the update_sc_rl_example branch from 5e1de03 to f3c7534 Compare May 17, 2022 06:45
learning_rate = 0.0005


class MyQNet(DiscreteQNet):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left DQN as an option

@Jinyu-W Jinyu-W merged commit 1f4af71 into sc_refinement May 17, 2022
@Jinyu-W Jinyu-W deleted the update_sc_rl_example branch May 17, 2022 08:36
@lihuoran lihuoran restored the update_sc_rl_example branch May 18, 2022 01:18
@lihuoran lihuoran deleted the update_sc_rl_example branch May 18, 2022 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants