Repository navigation
fix(docx_math): preserve multiple arguments in delimiter (<m:d>) and support sepChr (#2573) - #2654
Open
İlker Oğulcan SAYIN (iosayin) wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2573
Summary of Changes
oMath2Latex.do_d, collects all<m:e>base arguments in order usingprocess_children_listinstead ofprocess_children_dict(which previously overwrote all earlier arguments with the last one).sepChrtoPr.__val_tagsandPr.tag2methto read the delimiter separator character (with empty string support ifm:valis omitted).sepChrwhen specified, or defaults to|per the OMML / ECMA-376 specification.,), default separator (|), and multi-argument delimiters.