Ensure safe ExifTool usage: require >= 12.24 #1399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds version checking for ExifTool to prevent security vulnerabilities by ensuring only safe versions (12.24 or later) are used, protecting against CVE-2021-22204.
- Adds pre-execution version verification for ExifTool
- Implements fail-fast behavior when unsafe versions are detected
- Provides clear error messaging for version-related failures
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
azhao25
pushed a commit
to azhao25/markitdown
that referenced
this pull request
Oct 16, 2025
* feat: add version verification for ExifTool to ensure security compliance * fix: improve ExifTool version verification ---------
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds safety measures when markitdown invokes ExifTool, to avoid exposure to known issues (e.g., CVE-2021-22204).
Changes
Impact
Testing
Verify the failure path with ExifTool < 12.24.
Verify normal operation with ExifTool ≥ 12.24.