Skip to content

MarkItDown resets the warning filter #1068

@AdrianVollmer

Description

@AdrianVollmer

Hey, i think this is an amazing project!

I started to use markitdown in one of my projects and suddenly I got tons of warnings. I suspect it's because of this line:

According to the docs, catch_warning is not thread safe. I'm using markitdown in threads. Besides, I'm not sure why resetwarnings() is called at all. A lot of my dependencies probably have warning filters set, and this line disables them all.

Can we remove the finally clause or perform this check differently please? Thanks in advance!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions