fix: graceful error handling for empty/invalid Fara model responses #484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes microsoft#453 - Add validation for empty model responses with helpful error message - Add check for missing <tool_call> tag with debugging info - Handle case where <tool_call> is not followed by newline - Add check for empty tool call content - Improve error messages to help users diagnose model compatibility issues - Add comprehensive unit tests for _parse_thoughts_and_action method Signed-off-by: majiayu000 <1835304752@qq.com>
levidehaan
pushed a commit
to levidehaan/magentic-ui
that referenced
this pull request
Dec 31, 2025
- Add Anthropic Claude as a model provider option in the UI - New AnthropicModelConfigForm component for configuring Claude models - Support for claude-sonnet-4, claude-3-5-sonnet, claude-3-5-haiku, claude-3-opus - Backend validation for Anthropic provider aliases - Updated autogen-ext dependency to include anthropic extra - Improve Fara web surfer error handling (PR microsoft#484) - Add validation for empty/whitespace-only model responses - Check for required <tool_call> tag before parsing - Handle tool calls with or without newline delimiters - Provide descriptive error messages with response previews - Fall back gracefully from JSON to ast.literal_eval parsing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
<tool_call>tag with debugging info<tool_call>is not followed by newlineTest plan
_parse_thoughts_and_actionmethodpoe fmt- formatting passespoe lint- linting passespoe pyright- type checking passes