Python generator: use Mapping instead of Dict for type annotations #415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lheckemann
force-pushed
the
dict-to-mapping
branch
from
704e3c0 to
3babb53
Compare
|
@microsoft-github-policy-service agree |
karthiknadig
added
the
bug
|
I didn't touch most of the files mentioned in the lint; and ruff doesn't suggest any changes on the file I touched when running it locally. |
|
Run |
|
I will fix this in a separate PR, and rebase this branch. |
karthiknadig
force-pushed
the
dict-to-mapping
branch
from
3babb53 to
022f282
Compare
karthiknadig
previously approved these changes
Mar 28, 2025
eleanorjboyd
previously approved these changes
Mar 28, 2025
|
It looks like now there is a real |
lheckemann
dismissed stale reviews from eleanorjboyd and karthiknadig
via
e592728
lheckemann
force-pushed
the
dict-to-mapping
branch
from
022f282 to
e592728
Compare
lheckemann
force-pushed
the
dict-to-mapping
branch
from
e592728 to
6346a2a
Compare
|
Changed the types of the value dicts back to dict, that should fix it. |
eleanorjboyd
approved these changes
Mar 31, 2025
debonte
approved these changes
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #414