Skip to content

Add LVBS prod unsigned security profile - #4746

Open
Praveen K Paladugu (praveen-pk) wants to merge 1 commit into
microsoft:mainfrom
praveen-pk:lvbs-prod-unsigned-security-profile
Open

Praveen K Paladugu (praveen-pk) wants to merge 1 commit into
microsoft:mainfrom
praveen-pk:lvbs-prod-unsigned-security-profile

Conversation

@praveen-pk

Copy link
Copy Markdown
Contributor

Description

Unsinged LVBS images need a security profile that has:

  • Trusted Launch enabled
  • Secure Boot Disabled
  • TPM Enabled

This introduces this Security Profile.

Type of Change

  • Bug fix
  • [X ] New feature
  • Breaking change
  • Refactoring
  • Documentation update

Checklist

  • [ X] Description is filled in above
  • [X ] No credentials, secrets, or internal details are included
  • Peer review requested (if not, add required peer reviewers after raising PR)
  • Tests executed and results posted below

Test Validation

Key Test Cases:

verify_lvbs_kmpp is the test case that run with this Security Profile.

Tested Azure Marketplace Images:

  • Custom LVBS Image

Test Results


                     LvbsKmpp.verify_lvbs_kmpp: PASSED   

test result summary
TOTAL : 1
QUEUED : 0
ASSIGNED : 0
RUNNING : 0
FAILED : 0
PASSED : 1
SKIPPED : 0

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: fabfa82c-7b3e-41c3-b98b-adc7ef973782

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Implicit selection can disable Secure Boot, and libvirt advertises a profile its deployment mapping cannot handle.

Review effort: Balanced
Findings: 1 High severity · 1 Medium severity

Open (2)
What changed in this PR

Adds an Azure security profile for unsigned LVBS images using Trusted Launch with Secure Boot disabled.

Changes:

  • Registers lvbs-prod-unsigned and adds it to capability matching.
  • Configures Azure deployment parameters for the new profile.
  • Adds decoding, capability, and Secure Boot regression tests.

Suggested validation: run verify_lvbs_kmpp on the custom LVBS image and smoke_test on the marketplace image below.

Key Test Cases:
verify_lvbs_kmpp|smoke_test

Impacted LISA Features:
SecurityProfile

Tested Azure Marketplace Images:

  • microsoftcblmariner azure-linux-3 azure-linux-3-gen2 latest
File Description
selftests/​azure/​test_security_profile.py Tests decoding, capabilities, and deployment settings.
lisa/​util/​constants.py Defines the new profile identifier.
lisa/​sut_orchestrator/​azure/​features.py Advertises SKU support and configures deployment.
lisa/​sut_orchestrator/​azure/​common.py Adds image and VHD profile support.
lisa/​features/​security_profile.py Extends shared profile definitions and selection priority.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment on lines 26 to 30
SecurityProfileType.Standard,
SecurityProfileType.LvbsProdUnsigned,
SecurityProfileType.SecureBoot,
SecurityProfileType.CVM,
SecurityProfileType.Stateless,
search_space.SetSpace,
items=[
SecurityProfileType.Standard,
SecurityProfileType.LvbsProdUnsigned,
@LiliDeng

LiliDeng commented Oct 8, 2026

Copy link
Copy Markdown
Collaborator

Praveen K Paladugu (@praveen-pk) I'm not sure whether this combination is meaningful. Also, this case does not have the new requirement added to it.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants