Update napi-rs, relock #12
Conversation
| const isMuslFromReport = () => { | ||
| const report = typeof process.report.getReport === 'function' ? process.report.getReport() : null | ||
| let report = null | ||
| if (typeof process.report?.getReport === 'function') { |
There was a problem hiding this comment.
This to me strikes me as a mistake in napi-rs; they added a ?. here but I'm fully able to declare that the package should work in old versions of node.
There was a problem hiding this comment.
But, ?. is Node 14, so, whatever
|
Binding tests are failing :( |
|
Somehow, callbacks are broken. The rust code all seems right, yet we are getting all of the args passed into the callbacks as an array passed to the first arg, instead of actually spread as args. |
|
|
I reverted the lockfile thing since I don't think it's even used without I wrote a script to query each transitive dep and it seems like only So, this PR is not strictly needed, but probably wise anyway since I think I mismatched napi versions. |
jakebailey
changed the title
See below