Improve reliability in the face of fork/exec #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DxgKrnl will return ENOTTY if we have an open fd that wasn't opened by our process. If we have a "valid" (not -1) file descriptor, but we can't use it because of EBADF (already closed, e.g. from O_CLOEXEC) or ENOTTY (not closed, but not from our process), then go ahead and throw away our existing Fd and try to re-initialize it. Note that other handles won't be able to carry forward. Attempting to use any objects that are still alive from a fork will fail. This just allows the newly-forked process to be able to use graphics even if the forked-from process already was using it.
iourit
approved these changes
Sep 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DxgKrnl will return ENOTTY if we have an open fd that wasn't opened by our process. If we have a "valid" (not -1) file descriptor, but we can't use it because of
EBADF(already closed, e.g. fromO_CLOEXEC) orENOTTY(not closed, but not from our process), then go ahead and throw away our existing Fd and try to re-initialize it.Note that other handles won't be able to carry forward. Attempting to use any objects that are still alive from a fork will fail. This just allows the newly-forked process to be able to use graphics even if the forked-from process already was using it.