Add optional reason for why the client failed to apply an edit #637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DanTup would be cool if you could add it to the protocol as well (it is here: https://github.com/Microsoft/vscode-languageserver-node/blob/master/protocol/src/protocol.ts#L1928) |
|
@dbaeumer is this good? microsoft/vscode-languageserver-node#443 |
|
Yes. Thanks. |
|
@dbaeumer I'm not sure if it was intended, but the change to the protocol library was merged, but this one was not - so it's not in the spec currently. |
|
Sorry totally missed that. Thanks for pinging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #618.
@dbaeumer I don't know if this is all that's required, or if my description is good enough - but feel free to suggest changes and/or tweak.
(It'd also be good for VS Code to use this too, for example describing a version mismatch if that's the reason it rejects edits).