Skip to content

Add multirange support to range formatting #1556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Add multirange support to range formatting #1556

wants to merge 3 commits into from

Conversation

c-claeys
Copy link
Contributor

Add multiRange support to the rangeFormatting method with a new list field in the request.

See also #1536

Add multiRange support to the rangeFormatting method with a new list field in the request.

See also #1536
Fix range->ranges typo
@c-claeys
Copy link
Contributor Author

@dbaeumer Let me know if you have any questions or concerns about this. I have commits partially completed to add support for this in both https://github.com/microsoft/vscode and https://github.com/microsoft/vscode-languageserver-node but they depend on choices made here.

@dbaeumer
Copy link
Member

dbaeumer commented Oct 4, 2022

@c-claeys thanks for the PR. In general we don't add things to the specification without have an (prototype) implementation at least for one editor.

I suggest that you continue with ranges and have an implementation in VS Code and the LSP nodes modules. If these implementations seem solid then we can start specing the behaviour.

@dbaeumer
Copy link
Member

I will close the PR for now. We can reopen it when there is an implementation for at least one editor.

@dbaeumer dbaeumer closed this Oct 21, 2022
@tom-anders
Copy link

I will close the PR for now. We can reopen it when there is an implementation for at least one editor.

Since it has been implemented in microsoft/vscode#163190 now, can we reopen this issue?

@dbaeumer
Copy link
Member

I can't since the fork for the PR got deleted.

@tom-anders
Copy link

@c-claeys Are you interested in updating this PR or opening a new one?

@c-claeys
Copy link
Contributor Author

I'll open a new one. I think the old approach differed qualitatively from where we landed for the VSCode API. I deleted the fork too (looks like it's a support pain to restore).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants