-
Notifications
You must be signed in to change notification settings - Fork 861
Add multirange support to range formatting #1556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add multiRange support to the rangeFormatting method with a new list field in the request. See also #1536
Fix range->ranges typo
@dbaeumer Let me know if you have any questions or concerns about this. I have commits partially completed to add support for this in both https://github.com/microsoft/vscode and https://github.com/microsoft/vscode-languageserver-node but they depend on choices made here. |
@c-claeys thanks for the PR. In general we don't add things to the specification without have an (prototype) implementation at least for one editor. I suggest that you continue with |
I will close the PR for now. We can reopen it when there is an implementation for at least one editor. |
Since it has been implemented in microsoft/vscode#163190 now, can we reopen this issue? |
I can't since the fork for the PR got deleted. |
@c-claeys Are you interested in updating this PR or opening a new one? |
I'll open a new one. I think the old approach differed qualitatively from where we landed for the VSCode API. I deleted the fork too (looks like it's a support pain to restore). |
Uses the protocol changes proposed in microsoft/language-server-protocol#1556 Differential Revision: https://reviews.llvm.org/D150852
Add multiRange support to the rangeFormatting method with a new list field in the request.
See also #1536