No client capability for codeLens/resolve

[michaelpj]

I think there probably should be one since surely not all clients support it?

[dbaeumer]

In the current protocol the resolve request is defined as a request to resolve the command of a code lens. Instead of adding a separate capability we should do the same as we did for completion items: we should add a capability that list the properties that can be resolve lazy on a code lens.

[michaelpj]

Yes in principle, although the only field that can reasonably be resolved lazily is the command: you need the range to know anything about it and the data is just for resolve anyway. But we might add more fields in future, so I still think following the design of the others makes sense.

It's worth noting that this will potentially be a bit awkward for servers. Since there was no capability, servers have had to assume that clients support it, so they might behave badly if a client suddenly says that it doesn't. Still, I think it would be an improvement.

[dbaeumer]

Actually the client capability to list the items to be resolved lazily is already in since 3.16.0. See https://github.com/microsoft/vscode-languageserver-node/blob/dbaeumer/painful-yak-copper/protocol/src/common/protocol.ts#L3204

Since this is consistent with what we do for completion items I will close the issue.

[mfussenegger]

Actually the client capability to list the items to be resolved lazily is already in since 3.16.0. See https://github.com/microsoft/vscode-languageserver-node/blob/dbaeumer/painful-yak-copper/protocol/src/common/protocol.ts#L3204

Since this is consistent with what we do for completion items I will close the issue.

Where? The link doesn't work.

CodeLensClientCapabilities doesn't mention anything?

[dbaeumer]

Reopening. Looks like I was in the wrong file. Need to see what went wrong.