Fixes incorrect type name and factory method name generation in aliased scenario #5496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Validated beta TS generation with microsoftgraph/msgraph-beta-sdk-typescript#180 and run at https://dev.azure.com/microsoftgraph/Graph%20Developer%20Experiences/_build/results?buildId=165322&view=results |
baywet
approved these changes
Sep 30, 2024
andrueastman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5404
When trying to find the factory method in the
TypeScriptConventionService.csfile, the method was looking for the factory method in the from the namespace. In the event that a namespace is a child of the namespace has a factory method with the same name, this may find the incorrect method(that's why it was aliased).As the target model will be in the same file as its factory method, the PR narrows the search to work from the file searching from the namespace will be too broad.