Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Typescript process null values #5106

Merged
merged 6 commits into from
Aug 13, 2024

Conversation

Kindest13
Copy link
Contributor

Fixes microsoft/kiota-typescript#1188
2 part for processing null values

Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!
Can you please add a changelog entry? (unreleased, changed)
Can you also update the unit tests?

@Kindest13
Copy link
Contributor Author

Can you please add a changelog entry? (unreleased, changed)

Where to look for the example of changelog?

@andrueastman
Copy link
Member

@Kindest13 The changelog file is at the repository root. You just need to add an entry to the unreleased section.

https://github.com/microsoft/kiota/blob/main/CHANGELOG.md#unreleased

@Kindest13 Kindest13 requested a review from baywet August 10, 2024 07:08
baywet
baywet previously approved these changes Aug 13, 2024
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the changes!

@baywet baywet enabled auto-merge August 13, 2024 14:54
@baywet baywet merged commit 1762552 into microsoft:main Aug 13, 2024
199 of 208 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot write null to a nullable value
4 participants