Do not force LogLevel.Debug for DEBUG builds #4739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Never override an explicit `--log-level` option, even in DEBUG builds but default to the `Debug` log level for DEBUG builds and keep the `Warning` default for RELEASE builds.
There was a problem hiding this comment.
Thanks for raising this @0xced
Any chance you can include a changelog entry in the file at the repository root as well?
|
I just added a CHANGELOG entry in d2681e3. |
auto-merge was automatically disabled
May 30, 2024 06:10
Pull Request is not mergeable
auto-merge was automatically disabled
May 30, 2024 06:10
Pull Request is not mergeable
andrueastman
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Never override an explicit
--log-leveloption, even in DEBUG builds but default to theDebuglog level for DEBUG builds and keep theWarningdefault for RELEASE builds.