Filter out properties that exist in base type from serializer/deseria…

…lizer methods in models

src/Kiota.Builder/Writers/Php/CodeMethodWriter.cs

@@ -238,7 +238,7 @@ private void WriteSerializerBody(CodeMethod codeMethod, CodeClass parentClass, L
             if(inherits && implementsParsable)
                 writer.WriteLine($"parent::serialize({writerParameterName});");
             var customProperties = parentClass.GetPropertiesOfKind(CodePropertyKind.Custom);
-            foreach(var otherProp in customProperties) {
+            foreach(var otherProp in customProperties.Where(x => !x.ExistsInBaseType)) {
                 writer.WriteLine($"{writerParameterName}->{GetSerializationMethodName(otherProp.Type)}('{otherProp.SerializationName ?? otherProp.Name.ToFirstCharacterLowerCase()}', $this->{otherProp.Name.ToFirstCharacterLowerCase()});");
             }
             if(additionalDataProperty != null)
@@ -401,6 +401,7 @@ private void WriteDeserializerBody(CodeClass parentClass, LanguageWriter writer,
             if(fieldToSerialize.Any()) {
                 writer.IncreaseIndent();
                 fieldToSerialize
+                    .Where(x => !x.ExistsInBaseType)
                     .OrderBy(x => x.Name)
                     .Select(x => 
                         $"'{x.SerializationName ?? x.Name.ToFirstCharacterLowerCase()}' => function (ParseNode $n) use ({currentObjectName}) {{ {currentObjectName}->{x.Setter.Name.ToFirstCharacterLowerCase()}({GetDeserializationMethodName(x.Type, method)}); }},")

src/kiota/Properties/launchSettings.json

@@ -2,7 +2,7 @@
   "profiles": {
     "kiota": {
       "commandName": "Project",
-      "commandLineArgs": "--openapi C:\\src\\msgraph-sdk-powershell\\openApiDocs\\v1.0\\mail.yml -o C:\\Users\\darrmi\\source\\github\\darrelmiller\\OpenApiClient\\Generated -c GraphClient --loglevel Information"
+      "commandLineArgs": "--openapi https://raw.githubusercontent.com/microsoftgraph/msgraph-metadata/master/openapi/v1.0/openapi.yaml -l PHP -o C:\\Users\\pgichuhi\\projects\\Generated -c BaseGraphClient --log-level Information -n Microsoft\\Graph"
     }
   }
 }

tests/Kiota.Builder.Tests/Writers/Php/CodeMethodWriterTests.cs

@@ -203,6 +203,7 @@ public void WriteRequestExecutor()
             new object[] { new CodeProperty { Name = "dateValue", Type = new CodeType { Name = "DateTime" }, Access = AccessModifier.Private}, "$writer->writeDateTimeValue('dateValue', $this->dateValue);" },
             new object[] { new CodeProperty { Name = "duration", Type = new CodeType { Name = "duration" }, Access = AccessModifier.Private}, "$writer->writeDateIntervalValue('duration', $this->duration);" },
             new object[] { new CodeProperty { Name = "stream", Type = new CodeType { Name = "binary" }, Access = AccessModifier.Private}, "$writer->writeBinaryContent('stream', $this->stream);" },
+            new object[] { new CodeProperty { Name = "definedInParent", Type = new CodeType { Name = "string"}, ExistsInBaseType = true}, "$write->writeStringValue('definedInParent', $this->definedInParent);"}
         };
 
         [Theory]
@@ -233,7 +234,10 @@ public void WriteSerializer(CodeProperty property, string expected)
             _codeMethodWriter.WriteCodeElement(codeMethod, languageWriter);
             var result = stringWriter.ToString();
             Assert.Contains("public function serialize(SerializationWriter $writer)", result);
-            Assert.Contains(expected, stringWriter.ToString());
+            if (property.ExistsInBaseType)
+                Assert.DoesNotContain(expected, result);
+            else
+                Assert.Contains(expected, stringWriter.ToString());
         }
 
         [Fact]
@@ -479,6 +483,7 @@ public void WriteIndexerBody()
             new object[] { new CodeProperty { Name = "years", Type = new CodeType { Name = "int", CollectionKind = CodeTypeBase.CodeTypeCollectionKind.Array }, Access = AccessModifier.Private},
                 "'years' => function (ParseNode $n) use ($o) { $o->setYears($n->getCollectionOfPrimitiveValues())"
             },
+            new object[] { new CodeProperty{ Name = "definedInParent", Type = new CodeType { Name = "string"}, ExistsInBaseType = true }, "'definedInParent' => function (ParseNode $n) use ($o) { $o->setDefinedInParent($n->getStringValue())"}
         };
         private static CodeClass GetParentClassInStaticContext()
         {
@@ -509,7 +514,10 @@ public void WriteDeserializer(CodeProperty property, string expected)
             parentClass.AddProperty(property);
             _refiner.Refine(parentClass.Parent as CodeNamespace);
             languageWriter.Write(deserializerMethod);
-            Assert.Contains(expected, stringWriter.ToString());
+            if (property.ExistsInBaseType)
+                Assert.DoesNotContain(expected, stringWriter.ToString());
+            else
+                Assert.Contains(expected, stringWriter.ToString());
         }
 
         [Fact]