Skip to content

go files names should not end with _windows.go #4407

Closed

Description

We've had to patch the beta weekly releases for the longest time example
Now those changes are trickling down to v1.
Both set of manual changes are making our weekly releases costlier than they need to (somebody need to check why the CI failed, cherry-pick the patch etc...)

It turns out that some suffixes are special cased for code variants on the platform and since our build agents are mostly linux, the files ending with _windows.go are being excluded.

We should update the go Path segmenter to escape anything ending with:

  • _windows.go
  • _test.go
  • _unix.go
  • _others.go
  • _amd64.go

(there may be more, finding some official documentation on the topic would be helpful)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

Labels

Gohelp wantedIssue caused by core project dependency modules or librarytype:bugA broken experience

Type

No type

Projects

  • Status

    Done ✔️

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions