Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes serializeMultipartBody function signature. #1399

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

andrueastman
Copy link
Member

@andrueastman andrueastman commented Oct 2, 2024

Related to microsoft/kiota#5518

The serializeMultipartBody function does not match the ModelSerializerFunction<Parsable> type after updates made in #1248

BEGIN_COMMIT_OVERRIDE
fix: fixes serializeMultipartBody function to match the ModelSerializerFunction<Parsable> type after updates made in #1248
END_COMMIT_OVERRIDE

@andrueastman andrueastman merged commit f69c934 into main Oct 2, 2024
5 checks passed
@andrueastman andrueastman deleted the andrueastman/typeinconsitency branch October 2, 2024 19:26
@baywet
Copy link
Member

baywet commented Oct 2, 2024

@andrueastman it seems the release never triggered for some reason. Can you look into this when you have a few minutes please?

@andrueastman
Copy link
Member Author

Sorry. I hadn't realized this repo had moved to release please in this PR #1366. Looking into this.

@baywet
Copy link
Member

baywet commented Oct 3, 2024

I think we've established that empty commits do not trigger releases in other repos unfortunately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done ✔️
Development

Successfully merging this pull request may close these issues.

2 participants