Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/negative intervals #54

Merged
merged 5 commits into from
May 8, 2024
Merged

fix/negative intervals #54

merged 5 commits into from
May 8, 2024

Conversation

SilasKenneth
Copy link
Member

@SilasKenneth SilasKenneth commented Apr 29, 2024

  • Make sure negative date periods are correctly handled.

Closes microsoftgraph/msgraph-sdk-php#1504

Depends on: microsoft/kiota-abstractions-php#144

@SilasKenneth SilasKenneth requested a review from a team as a code owner April 29, 2024 13:55
@SilasKenneth SilasKenneth self-assigned this Apr 29, 2024
src/TextSerializationWriter.php Show resolved Hide resolved
src/TextParseNode.php Outdated Show resolved Hide resolved
@SilasKenneth
Copy link
Member Author

Converting this to draft to wait for microsoft/kiota-abstractions-php#144

@SilasKenneth SilasKenneth marked this pull request as draft April 29, 2024 15:31
@SilasKenneth SilasKenneth marked this pull request as ready for review May 6, 2024 12:55
Copy link

sonarcloud bot commented May 8, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
57.1% Coverage on New Code (required ≥ 80%)
D Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@SilasKenneth SilasKenneth merged commit 27536eb into dev May 8, 2024
6 of 7 checks passed
@SilasKenneth SilasKenneth deleted the fix/negative-intervals branch May 8, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrating from 1.96 to 2.4 booking service issue
2 participants