Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert from Async to Sync #770

Merged
merged 11 commits into from
Nov 10, 2023
Merged

Revert from Async to Sync #770

merged 11 commits into from
Nov 10, 2023

Conversation

ramsessanchez
Copy link
Contributor

@ramsessanchez ramsessanchez commented Nov 3, 2023 •
edited by baywet
Loading

Begin work to revert from Async to Sync for Java-Kiota components.

fixes #175

baywet
baywet requested changes Nov 6, 2023
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for starting this, a couple of comments to help fasttrack it.

components/abstractions/src/main/java/com/microsoft/kiota/ResponseHandler.java Outdated Show resolved Hide resolved
...tractions/src/main/java/com/microsoft/kiota/authentication/ApiKeyAuthenticationProvider.java Show resolved Hide resolved
...actions/src/main/java/com/microsoft/kiota/serialization/SerializationWriterProxyFactory.java Outdated Show resolved Hide resolved
...azure/src/main/java/com/microsoft/kiota/authentication/AzureIdentityAccessTokenProvider.java Show resolved Hide resolved
.../http/okHttp/src/main/java/com/microsoft/kiota/http/middleware/HeadersInspectionHandler.java Show resolved Hide resolved
components/abstractions/src/main/java/com/microsoft/kiota/RequestAdapter.java Outdated Show resolved Hide resolved
components/http/okHttp/src/main/java/com/microsoft/kiota/http/OkHttpRequestAdapter.java Outdated Show resolved Hide resolved
components/http/okHttp/src/main/java/com/microsoft/kiota/http/OkHttpRequestAdapter.java Outdated Show resolved Hide resolved
components/http/okHttp/src/main/java/com/microsoft/kiota/http/OkHttpRequestAdapter.java Show resolved Hide resolved
components/http/okHttp/src/main/java/com/microsoft/kiota/http/OkHttpRequestAdapter.java Outdated Show resolved Hide resolved
@ramsessanchez
Copy link
Contributor Author

appreciate the feedback and insight @baywet , thanks!

@ramsessanchez ramsessanchez marked this pull request as ready for review November 6, 2023 22:46
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 6, 2023

Please retry analysis of this Pull-Request directly on SonarCloud.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2023

Conflicts have been resolved. A maintainer will take a look shortly.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 8, 2023

Please retry analysis of this Pull-Request directly on SonarCloud.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 9, 2023

Please retry analysis of this Pull-Request directly on SonarCloud.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 9, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 43 Code Smells

0.0% 0.0% Coverage
22.1% 22.1% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 9, 2023

Please retry analysis of this Pull-Request directly on SonarCloud.

@ramsessanchez
Api Exception handling
cbe580b 
Changelog and Version
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 9, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell C 48 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

andrueastman
andrueastman previously approved these changes Nov 10, 2023
View reviewed changes
baywet
baywet requested changes Nov 10, 2023
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting really close!

CHANGELOG.md Outdated Show resolved Hide resolved
components/http/okHttp/src/main/java/com/microsoft/kiota/http/HeadersCompatibility.java Show resolved Hide resolved
gradle.properties Show resolved Hide resolved
components/http/okHttp/src/main/java/com/microsoft/kiota/http/OkHttpRequestAdapter.java Outdated Show resolved Hide resolved
components/http/okHttp/src/main/java/com/microsoft/kiota/http/OkHttpRequestAdapter.java Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 10, 2023

Please retry analysis of this Pull-Request directly on SonarCloud.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

baywet
baywet approved these changes Nov 10, 2023
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for making the changes

@ramsessanchez ramsessanchez merged commit 0a5cb30 into main Nov 10, 2023
10 checks passed
@ramsessanchez ramsessanchez deleted the rsh/syncRevert_java branch November 10, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

@MIchaelMainer MIchaelMainer Awaiting requested review from MIchaelMainer

@zengin zengin Awaiting requested review from zengin

@andreaTP andreaTP Awaiting requested review from andreaTP

@EricWittmann EricWittmann Awaiting requested review from EricWittmann

@andrueastman andrueastman Awaiting requested review from andrueastman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[discussion] Java Async
5 participants
@ramsessanchez @EricWittmann @andreaTP @andrueastman @baywet