Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: method POST must have a request body #243

Merged
merged 6 commits into from
Mar 16, 2023

Conversation

andreaTP
Copy link
Contributor

This is a fix for the issue found here:
bf2fc6cc711aee1a0c2a/e2e-test-suite#502 (comment)

// Unexpected exception thrown: java.lang.IllegalArgumentException: method POST must have a request body.

Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution.

CHANGELOG.md Outdated Show resolved Hide resolved
@andreaTP
Copy link
Contributor Author

@baywet should be ready to go 🙂

baywet
baywet previously approved these changes Mar 16, 2023
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the updates.

@baywet baywet enabled auto-merge March 16, 2023 13:22
auto-merge was automatically disabled March 16, 2023 14:29

Head branch was pushed to by a user without write access

@andreaTP
Copy link
Contributor Author

@baywet I missed an android linting thing, should be good now 👍 Looking for the release, and thanks a lot!

@baywet
Copy link
Member

baywet commented Mar 16, 2023

thanks for making the update, I didn't know you could put the attribute inline for the return type like you can for parameters.

@baywet baywet enabled auto-merge March 16, 2023 14:38
@baywet baywet merged commit 1d9ca7a into microsoft:main Mar 16, 2023
@andreaTP
Copy link
Contributor Author

thanks for making the update, I didn't know you could put the attribute inline for the return type like you can for parameters.

Oh, sorry, I haven't noticed that you are using a different style in this codebase, do you want me to follow up on this?
Also, since we are here 🙂 , do you have any opinionated automatic formatting tool for Java already in place somewhere?

@baywet
Copy link
Member

baywet commented Mar 16, 2023

I personally don't care about those things.

But we have some rules in spotbugs that do a very basic level of linting, I think that's about it for the linting today.

If you have spare time, setting up something like checkstyles or equivalent would be appreciated.

@andreaTP
Copy link
Contributor Author

I personally don't care about those things.

Forgot about it 😅 Right!

If you have spare time, setting up something like checkstyles or equivalent would be appreciated.

Deal, next time I jump on this codebase and feel bad because of the formatting I'll do it 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants