-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: method POST must have a request body #243
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution.
components/http/okHttp/src/main/java/com/microsoft/kiota/http/OkHttpRequestAdapter.java
Outdated
Show resolved
Hide resolved
@baywet should be ready to go 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the updates.
Head branch was pushed to by a user without write access
@baywet I missed an android linting thing, should be good now 👍 Looking for the release, and thanks a lot! |
thanks for making the update, I didn't know you could put the attribute inline for the return type like you can for parameters. |
Oh, sorry, I haven't noticed that you are using a different style in this codebase, do you want me to follow up on this? |
I personally don't care about those things. But we have some rules in spotbugs that do a very basic level of linting, I think that's about it for the linting today. If you have spare time, setting up something like checkstyles or equivalent would be appreciated. |
Forgot about it 😅 Right!
Deal, next time I jump on this codebase and feel bad because of the formatting I'll do it 🙂 |
This is a fix for the issue found here:
bf2fc6cc711aee1a0c2a/e2e-test-suite#502 (comment)