-
Notifications
You must be signed in to change notification settings - Fork 10
Conversation
if not set use default of 5
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably need to check on the failing CI due to linting errors as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have the same issue for the retry handler and I think we should take that opportunity to fix all the occurrences that pattern.
current_options.max_delay -= (end_time - start_time) |
Thanks for the changes @shemogumbe. Remember to add a CHANGELOG entry and bump package version once done. |
Thanks for the feedback @tpcgold |
Let's unblock users with this fix now but make sure we add the issue to the backlog to be resolved this quarter. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the guidance @isvargasmsft
@shemogumbe can you also add a changelog entry please?
Created #281 to follow up |
|
fixes #246