Update php-http/promise requirement from ~1.2.0 to ~1.2.0 || ~1.3.0 #159
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Updates the requirements on [php-http/promise](https://github.com/php-http/promise) to permit the latest version. - [Release notes](https://github.com/php-http/promise/releases) - [Changelog](https://github.com/php-http/promise/blob/1.x/CHANGELOG.md) - [Commits](php-http/promise@1.2.0...1.3.1) --- updated-dependencies: - dependency-name: php-http/promise dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
dependencies
|
Breaking |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
dependabot
bot
deleted the
dependabot/composer/php-http/promise-approx-1.2.0or-approx-1.3.0
branch
|
@SilasKenneth why do you consider this to be breaking? |
|
Version 1.3.0 removes the generics for Promise which were introduced in 1.2.0. Updating to 1.3 would mean that this /**
@returns Promise<Type>
**/
public function get(): Promise {}will no-longer be valid and this is used in the RequestAdapter |
|
Thanks for the additional context here. I remember the discussions at the time and it seems we collectively forgot about resolving this. Here is some more context Ideally: we'd be able to submit another pull request to the upstream dependency which enables genericity while solving the concerns that were discovered. Can you create an issue capturing all those aspects so we can schedule work on this please? |
Updates the requirements on php-http/promise to permit the latest version.
Release notes
Sourced from php-http/promise's releases.
Changelog
Sourced from php-http/promise's changelog.
... (truncated)
Commits
fc85b1fprepare release5caa0bcMerge pull request #34 from derrabus/bugfix/implicit-nullable35fa82dMake nullable parameter types explicit13d7636Merge pull request #33 from php-http/phpdoc-revert2916a60revert generic annotations44a67cbprepare release7fa2284Accept Throwable for onRejected and expand return type for wait() (#30)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)