[Bug] Incorrect/inverted log message in SearchClient

[ttrebuchon]

Context / Scenario

Any invocation of SearchClient.AskAsync(...) with a non-empty string passed in as the query parameter.

Relevant KM Source Line

(I'm pretty sure this is just a case of either a missing ! in front of the string.IsNullOrEmpty(query), or accidentally swapping the order of the messages in the ternary, but the github new-issue-flow is making it hard to figure out how to notify you all of a possible simple typo)

What happened?

A (trace) log message stating Fetching relevant memories by filtering only, no vector search was logged.

Expected:
The other log message in the ternary (Fetching relevant memories by similarity, min relevance {minRelevance}) is the one that makes sense.

Importance

edge case

Platform, Language, Versions

C#

Relevant log output

[...]
trce: Fetching relevant memories by filtering only, no vector search

[marcominerva]

@dluc, in addition to this issue, I have noticed that at line 82, IsNullOrWhitespace is used:

kernel-memory/service/Core/Search/SearchClient.cs

Line 82 in bd8d34e

if (string.IsNullOrWhiteSpace(query) && (filters == null || filters.Count == 0))

While in the rest of the method, the check is performed with IsNullOrEmpty. We probably should use IsNullOrWhitespace everywhere, do you agree?