runtime: skip empty Guest console output lines #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skip logging empty lines of text from the Guest console output, if there are any such lines. Without this change, the Guest console log from CLH + /dev/pts/0 has twice as many lines of text. Half of these lines are empty. Fixes: kata-containers#10737 Signed-off-by: Dan Mihai <dmihai@microsoft.com>
sprt
approved these changes
Jan 15, 2025
ms-mahuber
approved these changes
Jan 16, 2025
sprt
pushed a commit
that referenced
this pull request
Feb 10, 2025
runtime: skip empty Guest console output lines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip logging empty lines of text from the Guest console output, if there are any such lines.
Without this change, the Guest console log from CLH + /dev/pts/0 has twice as many lines of text. Half of these lines are empty.
Fixes: kata-containers#10737
Cherry-pick upstream commit 2e21f51