This repository was archived by the owner on Jun 14, 2024. It is now read-only.
Clean up Hyperspace-related configs #242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imback82
changed the title
imback82
commented
Nov 2, 2020
Comment on lines
-76
to
-89
| def indexCreationPath: Path = { | ||
| getOption(IndexConstants.INDEX_CREATION_PATH) | ||
| .map(new Path(_, IndexConstants.INDEXES_DIR)) | ||
| .getOrElse(new Path(systemPath, IndexConstants.INDEXES_DIR)) | ||
| } | ||
|
|
||
| /** | ||
| * Get the Hyperspace index search paths. | ||
| * | ||
| * @return Hyperspace index search paths. | ||
| */ | ||
| def indexSearchPaths: Option[Seq[String]] = { | ||
| getOption(IndexConstants.INDEX_SEARCH_PATHS) | ||
| .map(_.split(',').toSeq) |
Contributor
Author
There was a problem hiding this comment.
These are not currently not used. I will create a separate issue to implement this scenario.
2 tasks
Collaborator
|
LGTM thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context for this pull request?
Few clean ups related to configs:
spark.hyperspace.index.num.bucketstospark.hyperspace.index.numBuckets, but supports the legacy config.spark.hyperspace.index.creation.pathandspark.hyperspace.index.search.paths.What changes were proposed in this pull request?
This PR proposes to rename
spark.hyperspace.index.num.bucketstospark.hyperspace.index.numBucketsand clean up unused configs.Does this PR introduce any user-facing change?
No, since legacy config is still honored.
How was this patch tested?
Added new tests testing falling back to legacy configs.