Do not log error for CMK failures in Schema worker #1035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Microsoft.Health.SqlServer/Features/Storage/SqlServerSchemaDataStore.cs
Show resolved
Hide resolved
gunjitchhhatwal
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The exception first happens here, and is logged as an error
healthcare-shared-components/src/Microsoft.Health.SqlServer/Features/Storage/SqlServerSchemaDataStore.cs
Line 120 in ff171b2
We can see from the logs that later down the line its caught as a CMK error and handled correctly (no failure, log as information) but the error log is distracting to DRI
healthcare-shared-components/src/Microsoft.Health.SqlServer/Features/Schema/SchemaJobWorker.cs
Line 92 in ff171b2
Related issues
Addresses 125949
Testing
IsCMKErroris already testedSemver Change
Patch|Skip|Feature|Breaking