Skip to content

Conversation

@crosbymichael
Copy link

This vendors the hcsshim dependencies so that consistent builds can be produced.

@msftclas
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

❌ crosbymichael sign now
You have signed the CLA already but the status is still pending? Let us recheck it.

@crosbymichael
Copy link
Author

@jterry75 @jhowardmsft let me know if you want this and i'll sign the cla or push with my docker address as we probably already have a company one.

@jterry75
Copy link
Contributor

I personally am ok with vendoring here but I will leave this up to @jhowardmsft he knows this repo best

@lowenna
Copy link
Contributor

lowenna commented Aug 10, 2018

I think this makes sense, but I'll talk it over with @jstarks when he's back from PTO next week.

@jterry75
Copy link
Contributor

@crosbymichael - You can remove the 2nd commit. We fixed the go-winio build issue

Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
dcantah pushed a commit to dcantah/hcsshim that referenced this pull request Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants