shim: skip SandboxPlatform validation when platform is not explicitly set#2620
Merged
helsaawy merged 1 commit intomicrosoft:mainfrom Mar 6, 2026
Merged
Conversation
25e49d5 to
c53a9dc
Compare
helsaawy
approved these changes
Mar 5, 2026
helsaawy
requested changes
Mar 5, 2026
… set
When runtime options are non-empty (e.g., SandboxIsolation is set) but
SandboxPlatform is empty, skip the platform validation rather than
failing. The validation only needs to check that the spec and shim
options match when SandboxPlatform is explicitly configured.
containerd's default config (config_windows.go) sets SandboxIsolation=1
for the runhcs-wcow-hypervisor runtime handler but omits SandboxPlatform,
making options non-empty with an empty platform string. This causes
platforms.Parse("") to fail with 'invalid runtime sandbox platform'.
Signed-off-by: Dawei Wei <wei.dawei.cn@gmail.com>
c53a9dc to
76b1208
Compare
rawahars
approved these changes
Mar 6, 2026
helsaawy
approved these changes
Mar 6, 2026
msft-linliu
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2619
When containerd's default
runhcs-wcow-hypervisorruntime config setsSandboxIsolation=1withoutSandboxPlatform, the shim options are non-empty butSandboxPlatformis"". The platform validation added in PR #2473 unconditionally callsplatforms.Parse("")which fails, breaking all Hyper-V isolated containers on stock containerd v2.2.1+.Changes
In
createInternal(), add a guard to skip platform validation whenSandboxPlatformis empty:When
SandboxPlatformis not explicitly configured, there is nothing meaningful to validate -- inferring the platform from the OCI spec and then validating the spec against the inference would be tautologically true (as noted by @helsaawy in review).Root Cause
containerd's
config_windows.godefaults:This makes
emptyShimOpts = false(options are non-empty due toSandboxIsolation), butSandboxPlatformis"", causing the validation to fail.Testing
invalid runtime sandbox platform: ""error on every Hyper-V pod[Feature:WindowsHyperVContainers]test suite passes with the patched shim