Skip to content

add EVD support for LCOW #2554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add EVD support for LCOW #2554

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions internal/hcsoci/resources_lcow.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ func allocateLinuxResources(ctx context.Context, coi *createOptionsInternal, r *
case MountTypeBind:
case MountTypePhysicalDisk:
case MountTypeVirtualDisk:
case MountTypeExtensibleVirtualDisk:
default:
// Unknown mount type
continue
Expand Down Expand Up @@ -129,6 +130,25 @@ func allocateLinuxResources(ctx context.Context, coi *createOptionsInternal, r *
mt = "bind"
}
coi.Spec.Mounts[i].Type = mt
} else if mount.Type == MountTypeExtensibleVirtualDisk {
l.Debug("hcsshim::allocateLinuxResources Hot-adding ExtensbleVirtualDisk")
scsiMount, err := coi.HostingSystem.SCSIManager.AddExtensibleVirtualDisk(
ctx,
hostPath,
readOnly,
"",
&scsi.MountConfig{Options: mount.Options, BlockDev: isBlockDev},
)
if err != nil {
return fmt.Errorf("adding Extensible virtual disk mount %+v: %w", mount, err)
}
r.Add(scsiMount)
uvmPathForFile = scsiMount.GuestPath()
mt := "none"
if isBlockDev {
mt = "bind"
}
coi.Spec.Mounts[i].Type = mt
} else if strings.HasPrefix(mount.Source, guestpath.SandboxMountPrefix) ||
strings.HasPrefix(mount.Source, guestpath.SandboxTmpfsMountPrefix) ||
strings.HasPrefix(mount.Source, guestpath.UVMMountPrefix) {
Expand Down
1 change: 1 addition & 0 deletions internal/uvm/scsi/manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,7 @@ func (m *Manager) AddExtensibleVirtualDisk(
options: mc.Options,
ensureFilesystem: mc.EnsureFilesystem,
filesystem: mc.Filesystem,
blockDev: mc.BlockDev,
}
}
return m.add(ctx,
Expand Down