Enable Windows UVM functional tests #2338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiechen0826
force-pushed
the
jiechen3/github_runner
branch
from
8017e0c to
6224605
Compare
jiechen0826
changed the title
jiechen0826
force-pushed
the
jiechen3/github_runner
branch
3 times, most recently
from
c927613 to
2b1e602
Compare
jiechen0826
force-pushed
the
jiechen3/github_runner
branch
6 times, most recently
from
057aebc to
12298b6
Compare
jiechen0826
changed the title
helsaawy
reviewed
Jan 13, 2025
jiechen0826
force-pushed
the
jiechen3/github_runner
branch
from
ee99100 to
15bfaaf
Compare
Co-authored-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com> Signed-off-by: Jie Chen <jiechen3@microsoft.com>
jiechen0826
force-pushed
the
jiechen3/github_runner
branch
from
15bfaaf to
c38d436
Compare
helsaawy
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the Windows UVM tests in the hcsshim functional test suite. It is done so by removing
uvmfrom the exclusion flag of the test execution. In addition, the default gitHub runner was replaced with the 1ES gitHub runners which support nested virtualization.Before the PR change, in the
test-windowsCI job, the stepbuild and run functional testing binaryshows result: DONE 70 tests, 38 skipped in 37.046sAfter the PR change, in the
test-windowsCI job, the stepbuild and run functional testing binaryshows result:: DONE 167 tests, 28 skipped in 476.079s
Note: Linux UVM tests will be enabled in a follow-up PR as it requires additional changes.