-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dmverity tool to take a directory as input to create a VHD #2274
Conversation
46bbdf9
to
ea8559a
Compare
i am not sure the tar creation should be part of dmverity/our package, since we are basically always guaranteed that |
@helsaawy the tar creation is taking a directory of files and tarring it so that it can be run through the tooling to generate a VHD with the merkel tree. This is for the scenario where we are not creating a VHD from image layers, but rather, a directory of other files and subdirectories. |
in that scenario, can't you just call |
Yes, but that adds an extra step for the user. |
I don't think that this should be |
…rosoft#2270) Make tar2ext4 deterministic with files without parent dir in tar Signed-off-by: Takuro Sato <takurosato@microsoft.com> Signed-off-by: Heather Garvison <hgarvison@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
When creating HCS doc for SNP UVM with verity boot, the SCSI controllers are overriden to always have only a single SCSI controller. This limits the max number of container layers to 64. Signed-off-by: Maksim An <maksiman@microsoft.com> Signed-off-by: Heather Garvison <hgarvison@microsoft.com>
Signed-off-by: Heather Garvison <hgarvison@microsoft.com>
Resolving comment to keep image flag available Co-authored-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com> Signed-off-by: Heather Garvison <hgarvison@microsoft.com>
Signed-off-by: Heather Garvison <hgarvison@microsoft.com>
Signed-off-by: Heather Garvison <hgarvison@microsoft.com>
Update dmverity tool to take a file directory as input, tar it, and create a VHD.