Update dmverity tool to fix bug where hdv creation fails #2234
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update dmverity tool to fix bug where hdv creation fails to move all VHDs from the temp dir.
To recreate the error, run:
go run cmd\dmverity-vhd\main.go create -i python:latest -o python_layers -hdv
You will notice the following output:
hash device created at python_layers\8f4ceb8cc1a2056b98f0424fad4715dd334aecc9769186b3ea0394f131524e27.hash-dev.vhd
hash device created at python_layers\916d866d5b0dc17158c78e5a09717fcf619b04450125caafa9c1b8f7aa6a2c45.hash-dev.vhd
hash device created at python_layers\0d80db6a0977d5ade37d5d248772c0e9aaa1b6c898ddb31b26c803ee1a9f57a2.hash-dev.vhd
hash device created at python_layers\28e03088bc157bfe42d66970cf7f47de35821aabaece5f767804902a8fa1d779.hash-dev.vhd
hash device created at python_layers\2c3d7750fa05a52d63169a54cb95f1c7415cff5abe04d8e8f083b1a66a7a90fc.hash-dev.vhd
hash device created at python_layers\418eda943d8d99d77490798330feb2fe1bf339821c6e7f6a316f5f49f597fa40.hash-dev.vhd
hash device created at python_layers\06a1f32472403fd53c9111fb980487a0cb32c74326d0e86b4dee72c0f3d19922.hash-dev.vhd
hash device created at python_layers\5f7a708450e3b4ba4ab4f748eb69eede08cdce541dd8280a3ad57dbf6a0d1ed2.hash-dev.vhd
Layer VHD created at python_layers\8f4ceb8cc1a2056b98f0424fad4715dd334aecc9769186b3ea0394f131524e27.vhd
layer VHD C:\Users<user>\AppData\Local\Temp\8f4ceb8cc1a2056b98f0424fad4715dd334aecc9769186b3ea0394f131524e27.hash-dev.vhd does not exist
exit status 1
After including this fix, the output is:
hash device created at python_layers\8f4ceb8cc1a2056b98f0424fad4715dd334aecc9769186b3ea0394f131524e27.hash-dev.vhd
hash device created at python_layers\916d866d5b0dc17158c78e5a09717fcf619b04450125caafa9c1b8f7aa6a2c45.hash-dev.vhd
hash device created at python_layers\0d80db6a0977d5ade37d5d248772c0e9aaa1b6c898ddb31b26c803ee1a9f57a2.hash-dev.vhd
hash device created at python_layers\28e03088bc157bfe42d66970cf7f47de35821aabaece5f767804902a8fa1d779.hash-dev.vhd
hash device created at python_layers\2c3d7750fa05a52d63169a54cb95f1c7415cff5abe04d8e8f083b1a66a7a90fc.hash-dev.vhd
hash device created at python_layers\418eda943d8d99d77490798330feb2fe1bf339821c6e7f6a316f5f49f597fa40.hash-dev.vhd
hash device created at python_layers\06a1f32472403fd53c9111fb980487a0cb32c74326d0e86b4dee72c0f3d19922.hash-dev.vhd
hash device created at python_layers\5f7a708450e3b4ba4ab4f748eb69eede08cdce541dd8280a3ad57dbf6a0d1ed2.hash-dev.vhd
Layer VHD created at python_layers\8f4ceb8cc1a2056b98f0424fad4715dd334aecc9769186b3ea0394f131524e27.vhd
Layer VHD created at python_layers\916d866d5b0dc17158c78e5a09717fcf619b04450125caafa9c1b8f7aa6a2c45.vhd
Layer VHD created at python_layers\0d80db6a0977d5ade37d5d248772c0e9aaa1b6c898ddb31b26c803ee1a9f57a2.vhd
Layer VHD created at python_layers\28e03088bc157bfe42d66970cf7f47de35821aabaece5f767804902a8fa1d779.vhd
Layer VHD created at python_layers\2c3d7750fa05a52d63169a54cb95f1c7415cff5abe04d8e8f083b1a66a7a90fc.vhd
Layer VHD created at python_layers\418eda943d8d99d77490798330feb2fe1bf339821c6e7f6a316f5f49f597fa40.vhd
Layer VHD created at python_layers\06a1f32472403fd53c9111fb980487a0cb32c74326d0e86b4dee72c0f3d19922.vhd
Layer VHD created at python_layers\5f7a708450e3b4ba4ab4f748eb69eede08cdce541dd8280a3ad57dbf6a0d1ed2.vhd