Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: temp file leak during hash computation #1641

Merged

Conversation

anmaxvl
Copy link
Contributor

@anmaxvl anmaxvl commented Feb 2, 2023

Fix a temp file leak when computing dmverity root hash. This mainly
affects dmverity-vhd tool and users may see their temp storage filling up.

Signed-off-by: Maksim An maksiman@microsoft.com

Fix a temp file leak when computing dmverity root hash. This
mainly affects `dmverity-vhd` tool and users may see their temp
storage filling up.

Signed-off-by: Maksim An <maksiman@microsoft.com>
@anmaxvl anmaxvl requested a review from a team as a code owner February 2, 2023 16:35
@anmaxvl
Copy link
Contributor Author

anmaxvl commented Feb 2, 2023

thanks @SethHollandsworth, FYI

Copy link
Contributor

@msscotb msscotb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@anmaxvl anmaxvl merged commit 69927ff into microsoft:main Feb 14, 2023
@anmaxvl anmaxvl deleted the fix/file-leak-after-hash-computation branch February 14, 2023 08:47
KenGordon pushed a commit to KenGordon/hcsshim that referenced this pull request May 17, 2024
Fix a temp file leak when computing dmverity root hash. This
mainly affects `dmverity-vhd` tool and users may see their temp
storage filling up.

Signed-off-by: Maksim An <maksiman@microsoft.com>
(cherry picked from commit 69927ff)
KenGordon pushed a commit to KenGordon/hcsshim that referenced this pull request May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants